Skip to content

Commit

Permalink
update task queued/processing when doing cross-check (#413)
Browse files Browse the repository at this point in the history
* update task queued/processing when doing cross-check

* make sure completion action accepts queued status

* <bot> update requirements-docs.txt

* <bot> update requirements-tests.txt

* <bot> update requirements.txt

---------

Co-authored-by: github-actions <[email protected]>
  • Loading branch information
dsschult and github-actions authored Jan 3, 2025
1 parent 2fc4b00 commit 5160c7c
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion iceprod/rest/handlers/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ async def post(self, task_id):

filter_query = {
'task_id': task_id,
'status': 'processing',
'status': {'$in': task_prev_statuses('complete')},
'instance_id': data['instance_id'],
}
update_query = {
Expand Down
2 changes: 2 additions & 0 deletions iceprod/server/plugins/condor.py
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,8 @@ async def check(self):
reason = extra.get('HoldReason', 'Job has failed')
logger.info("job %s %s.%s removed from cross-check: %r", job_id, job.dataset_id, job.task_id, reason)
self.submitter.remove(job_id, reason=reason)
else:
self.job_update(job)

await self.check_history()

Expand Down
2 changes: 1 addition & 1 deletion iceprod/server/states.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
'idle': ['waiting', 'suspended'],
'waiting': ['queued', 'idle', 'suspended'],
'queued': ['processing', 'idle', 'waiting', 'suspended', 'failed', 'complete'],
'processing': ['idle', 'waiting', 'suspended', 'failed', 'complete'],
'processing': ['idle', 'waiting', 'queued', 'suspended', 'failed', 'complete'],
'suspended': ['idle', 'waiting'],
'failed': ['idle', 'waiting'],
'complete': [],
Expand Down
4 changes: 2 additions & 2 deletions requirements-docs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ attrs==24.3.0
# referencing
babel==2.16.0
# via sphinx
boto3==1.35.91
boto3==1.35.92
# via iceprod (setup.py)
botocore==1.35.91
botocore==1.35.92
# via
# boto3
# s3transfer
Expand Down
4 changes: 2 additions & 2 deletions requirements-tests.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ attrs==24.3.0
# referencing
beautifulsoup4==4.12.3
# via iceprod (setup.py)
boto3==1.35.91
boto3==1.35.92
# via
# iceprod (setup.py)
# moto
botocore==1.35.91
botocore==1.35.92
# via
# boto3
# moto
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ attrs==24.3.0
# via
# jsonschema
# referencing
boto3==1.35.91
boto3==1.35.92
# via iceprod (setup.py)
botocore==1.35.91
botocore==1.35.92
# via
# boto3
# s3transfer
Expand Down

0 comments on commit 5160c7c

Please sign in to comment.