-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Typing #80
Metadata Typing #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type information generally looks good. I guess one question is how to fit the rest of the columns in the metadata doc.
# /data/exp/* i3 File: | ||
software: Optional[List[SoftwareEntry]] | ||
run: Run | ||
offline_processing_metadata: OfflineProcessingMetadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we really using such a long name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I think this is the longest name
We can put each description as an inline comment. For whether the key is required, that would need to be an independent dict. |
We could really go all out and duplicate/migrate the Google Doc into a dict/yaml. But this is beyond the scope of this PR |
Fair enough. |
|
schema/types.py
containing metadata type hintsvalidation.py
to validate metadata using introspection (future)validation.py
toschema/validation.py