really fix mypy

WIPACrepo · Dec 21, 2023 · 3bae579 · 3bae579
1 parent 96fd3f4
commit 3bae579
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/resources/cleanup_scripts/restore_from_backup.py b/resources/cleanup_scripts/restore_from_backup.py
@@ -27,7 +27,7 @@ async def already_in_fc(rc: RestClient, uuid: str, logical_name: str) -> bool:
         await rc.request("GET", "/api/files/" + uuid)
         return True
     except requests.exceptions.HTTPError as e:
-        if e and e.response.status_code != 404:
+        if e.response and e.response.status_code != 404:
             raise
 
     # now sanity check that the logical_name isn't already in the FC

diff --git a/tests/test_files.py b/tests/test_files.py
@@ -40,8 +40,8 @@ def copy_without_rest_response_keys(data: StrDict) -> StrDict:
 def _assert_httperror(exception: Exception, code: int, reason: str) -> None:
     """Assert that this is the expected HTTPError."""
     print(exception)
-    assert exception is not None
     assert isinstance(exception, requests.exceptions.HTTPError)
+    assert exception.response is not None
     assert exception.response.status_code == code
     assert exception.response.reason == reason
 

diff --git a/tests/test_server.py b/tests/test_server.py
@@ -13,8 +13,8 @@
 def _assert_httperror(exception: Exception, code: int, reason: str) -> None:
     """Assert that this is the expected HTTPError."""
     print(exception)
-    assert exception is not None
     assert isinstance(exception, requests.exceptions.HTTPError)
+    assert exception.response is not None
     assert exception.response.status_code == code
     assert exception.response.reason == reason