-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an algorithm of storage maintenance (IG Cap). #859
Conversation
It includes several IG caps.
@orrb1 PTAL. Thanks! Not sure why I cannot add you to the reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @qingxinwu!
spec.bs
Outdated
|
||
There is a job that periodically [=performs storage maintenance=] on the [=user agent=]'s | ||
[=interest group set=]. It performs operations such as [=list/removing=] expired or excess | ||
[=interest groups=]. An [=interest group set=] must have no more than: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domfarolino Should we define these numbers as "Vendor (or Implementation) Specific Values" as some specs do? I'd think so, since we're fine with vendors choose their own numbers for these, instead of sticking with our pick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % discussion in https://github.com/WICG/turtledove/pull/859/files#r1357262550, which I'd like to understand better.
How about this comment about defining the limits as "vendor specific values"? We also want to provide our limits as an example for people to start with if they want, so wondering what would be the best format/wording (e.g., an "Example" with our numbers, or "Note" for that, etc.) |
Hmm, so there seems to be two places where we might want to introduce implementation-defined "looseness" around IG size, and I'm not sure what the difference is:
Are both of these desirable? Or are both of these just different ways of achieving the same thing? |
They're different things. I'll keep the size estimation part under the other comment (and it turns out that's no longer a problem). Here, it's about the size limitation an implementation/vendor might want to put on stored IGs, such as total maximum sizes of IGs per owner. We chose our numbers for those limitations, but we'd like to allow other vendors to choose their limitations as they want if their browser can handle more/less limits (e.g., allow storing more IGs per owner, give higher storage limit per owner, etc.), and our numbers are examples and start point for them. If they'd like to use the same numbers, that's fine as well. |
OK thanks for clarifying. In that case, I'd say something like:
That can go above the definition of the constants you define. Does that make sense? |
Done. That sounds great. Thanks |
I gave this a quick review and it LGTM. |
SHA: 07960ec Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 07960ec Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
It includes several IG caps.
Also link "user agent" to Infra's [=user agent=].
Preview | Diff