Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Seller / bid nonce #1313

Merged
merged 12 commits into from
Nov 13, 2024
Merged

[Spec] Seller / bid nonce #1313

merged 12 commits into from
Nov 13, 2024

Conversation

caraitto
Copy link
Collaborator

@caraitto caraitto commented Oct 25, 2024 •
edited by pr-preview bot
Loading

Also, fix a couple minor issues.

Preview | Diff

@caraitto caraitto requested a review from orrb1 October 25, 2024 14:05
@JensenPaul JensenPaul added the spec Relates to the spec label Oct 28, 2024
orrb1
orrb1 reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Caleb!

spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@orrb1 orrb1 mentioned this pull request Nov 5, 2024
Open
@caraitto caraitto requested a review from orrb1 November 7, 2024 17:43
orrb1
orrb1 reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Caleb!

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
@caraitto
Copy link
Collaborator Author

caraitto commented Nov 7, 2024

@orrb1 PTAL at #1313 (comment) -- is the new wording OK?

@caraitto caraitto requested a review from orrb1 November 7, 2024 23:05
orrb1
orrb1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Caleb!

@caraitto
Copy link
Collaborator Author

caraitto commented Nov 11, 2024 •
edited
Loading

NOTE: This isn't quite ready to merge yet since #1313 (comment) is unresolved.

orrb1
orrb1 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Caleb.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@caraitto
Copy link
Collaborator Author

OK, I think this is now ready to merge, thanks Orr!

@caraitto caraitto requested a review from JensenPaul November 12, 2024 16:45
@JensenPaul JensenPaul merged commit e5f3f47 into WICG:main Nov 13, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 13, 2024
@caraitto @github-actions
[Spec] Seller / bid nonce (#1313)
97b58c8 
SHA: e5f3f47
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@caraitto caraitto deleted the seller-nonce branch November 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrb1 orrb1 orrb1 approved these changes

@JensenPaul JensenPaul Awaiting requested review from JensenPaul

Assignees
No one assigned
Labels
spec Relates to the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caraitto @orrb1 @JensenPaul