Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Qingxin Wu committed Dec 2, 2024
1 parent 32bf545 commit 3f63b2d
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -3098,7 +3098,6 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=reporting context map=]
[=interest group ad/render url=], then set |winningAd| to |ad|, and [=iteration/break=].
1. Return failure if any of the following conditions hold:
* |winningAd| is null;
* the result of running [=query generated bid k-anonymity count=] with |winningAd| is false;
* |response|'s [=server auction response/buyer and seller reporting id=] is not null and not
|winningAd|'s [=interest group ad/buyer and seller reporting ID=];
* |response|'s [=server auction response/buyer reporting id=] is not null and not
Expand Down Expand Up @@ -3464,7 +3463,7 @@ A <dfn>server auction response</dfn> is a [=struct=] that contains auction resul
:: Null or a [=string=]. When not null, this will be verified with the winning bid's
[=generated bid/ad=]'s [=interest group ad/buyer and seller reporting ID=].
: <dfn>selected buyer and seller reporting id</dfn>
:: Null or a [=string=]. When not null, this will be verified with the winning bid's
:: Null or a [=string=], initially null. When not null, this will be verified with the winning bid's
[=generated bid/ad=]'s [=interest group ad/selectable buyer and seller reporting IDs=].
: error
:: Null or [=string=]. When not null, contains an error message from the
Expand Down Expand Up @@ -6405,15 +6404,14 @@ To <dfn>convert GenerateBidOutput to generated bid</dfn> given a {{GenerateBidOu
1. If |ad|'s [=interest group ad/render url=] does not equal |adUrl|, [=iteration/continue=].
1. If |ad|'s [=interest group ad/size group=] is null and |adSize| is null, set |maybeMatchingAd|
to |ad|, and [=iteration/break=].
1. If one of |ad|'s [=interest group ad/size group=] |adSize| is null, set |maybeMatchingAd| to
|ad|, and [=iteration/break=].
1. If one of |ad|'s [=interest group ad/size group=] OR |adSize| is null, set |maybeMatchingAd|
to |ad|, and [=iteration/break=].

Note: When only one of the two ads has a size specification, they are considered matching. The
caller is responsible for discarding the extraneous size information.
1. [=list/For each=] |igSize| in (|ig|'s [=interest group/size groups=])[|ad|'s
[=interest group ad/size group=]]:
1. If |igSize| equals |adSize|, set |maybeMatchingAd| to |ad|, and [=iteration/break=].
1. If
1. Return null.
</div>

Expand Down

0 comments on commit 3f63b2d

Please sign in to comment.