Automated tests #650
Closed
Automated tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inventory ui, deployment task, bulk validation fixes
Upload Deployment Csv Changes
Update Chromedriver Version 101.0.4951.41
Deployment Import: assembly, assembly revision, comment skip fixes
Automatically Determine Chromedriver Version
deployment import and cruise event bugfixes
enhancement #401 - added CCC values to search display table and csv download
Deployment Import: AssemblyPart Duplication Hotfix
Deployment Import: AssemblyPart Duplication Hotfix
Deployment Import AssemblyPart duplication hotfix
Bulk CSV Import: Inventory Deadlock Hotfix
…undabout into release-1.7.0
…roundabout into mario_dev_1.7.0
Deployment Bulk Import: Reference Designator validation and parsing hotfix
AssemblyPart Reference Designator Update Hotfix
refdes updater hotfix
bulk deployment inventorydeployment hotfix
Mario dev 1.7.0
|
Hey Joanne
I think you merged this into the wrong branch? You’re new code should be merged into the 1.7.0 branch, right?
From: Joanne Koch ***@***.***>
Date: Monday, August 14, 2023 at 3:09 PM
To: WHOIGit/ooicgsn-roundabout ***@***.***>
Cc: Ethan Andrews ***@***.***>, Review requested ***@***.***>
Subject: [EXTERNAL] Re: [WHOIGit/ooicgsn-roundabout] Automated tests (PR #650)
This email originated outside of WHOI. Please use caution if clicking on links or opening attachments.
@joannekoch<https://github.com/joannekoch> requested your review on: #650<#650> Automated tests.
—
Reply to this email directly, view it on GitHub<#650 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJPWKNVAD4FQO56VA6K4GF3XVJZX3ANCNFSM6AAAAAA3QDLVQA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Yes, I did. It's been a while...
I'll create a new pull request and try to delete this one.
Joanne
From: Ethan Andrews ***@***.***>
Sent: Tuesday, August 15, 2023 9:02 AM
To: WHOIGit/ooicgsn-roundabout ***@***.***>
Cc: Joanne Koch ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [WHOIGit/ooicgsn-roundabout] Automated tests (PR #650)
This email originated outside of WHOI. Please use caution if clicking on links or opening attachments.
Hey Joanne
I think you merged this into the wrong branch? You're new code should be merged into the 1.7.0 branch, right?
From: Joanne Koch ***@***.***>
Date: Monday, August 14, 2023 at 3:09 PM
To: WHOIGit/ooicgsn-roundabout ***@***.***>
Cc: Ethan Andrews ***@***.***>, Review requested ***@***.***>
Subject: [EXTERNAL] Re: [WHOIGit/ooicgsn-roundabout] Automated tests (PR #650)
This email originated outside of WHOI. Please use caution if clicking on links or opening attachments.
@joannekoch<https://github.com/joannekoch> requested your review on: #650<#650> Automated tests.
-
Reply to this email directly, view it on GitHub<#650 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJPWKNVAD4FQO56VA6K4GF3XVJZX3ANCNFSM6AAAAAA3QDLVQA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
-
Reply to this email directly, view it on GitHub<#650 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APTCWYQQJMIHG6XQK6EDN63XVNXL3ANCNFSM6AAAAAA3QDLVQA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Merge into wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Chrome version 115, download Chromedriver from a new location, Chromedriver for Testing (https://googlechromelabs.github.io/chrome-for-testing/).