docs: update DockerFile and add a docker-compose example
#1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlayerOrnstein
changed the title
DockerFile and as a docker-compose exampleDockerFile and add a docker-compose example
TobiTenno
reviewed
May 13, 2024
I actually forgot to change the image name from the example image
TobiTenno
approved these changes
May 15, 2024
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you fix?
Not actually sure if this is a
docs,fix, orfeatsince I'm not sure where docker is used but seeing that WFCD/warframe-items#570 requires NodeJS >18 I thought it would be a good idea to line this up with LTS releases.For the port, in the context of containers it's best to just listen to the localhost and expose 3001 since the user can expose the guest port over whatever host port they want, they just have to fill the other env variables during
docker runor the compose fileReproduction steps
Evidence/screenshot/link to line
Considerations