Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traffic light launch file #80

Merged
merged 12 commits into from
Mar 8, 2024
Merged

Add traffic light launch file #80

merged 12 commits into from
Mar 8, 2024

Conversation

Gongsta
Copy link
Member

@Gongsta Gongsta commented Feb 21, 2024 •
edited
Loading

Add a traffic light launch file, which uses a fine-tuned YOLOv8 model that is mounted and launched through the CameraObjectDetection node.

@Gongsta Gongsta marked this pull request as ready for review February 23, 2024 04:36
@Gongsta Gongsta requested a review from Edwardius February 23, 2024 04:46
@Gongsta
Copy link
Member Author

Gongsta commented Feb 23, 2024 •
edited
Loading

change in coordinate frames (back into the original image) will be fixed in another pr.

Update: Fixed it in this PR

@Gongsta Gongsta requested a review from leungjch March 1, 2024 01:22
@leungjch
Copy link
Contributor

leungjch commented Mar 1, 2024

lgtm, seems like theres merge conflicts

@Miniapple8888 Miniapple8888 mentioned this pull request Mar 1, 2024
Merged
Edwardius
Edwardius approved these changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@Edwardius Edwardius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just address comments

modules/docker-compose.perception.yaml Outdated Show resolved Hide resolved
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py Show resolved Hide resolved
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py Show resolved Hide resolved
@Edwardius
Copy link
Collaborator

also add description of pr

@Gongsta Gongsta merged commit c84e554 into main Mar 8, 2024
28 checks passed
@Gongsta Gongsta mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edwardius Edwardius Edwardius approved these changes

@leungjch leungjch leungjch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gongsta @leungjch @Edwardius