Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drivers for lidar and camera #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

stuff

3f9d2a8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Add drivers for lidar and camera #75

stuff
3f9d2a8
Select commit
Loading
Failed to load commit list.
GitHub Actions / Autopep8 failed Apr 4, 2024 in 0s

4 errors

Autopep8 found 4 errors

Annotations

Check failure on line 29 in src/interfacing/sensor_interfacing/launch/include/cameras.launch.py

See this annotation in the file changed.

@github-actions github-actions / Autopep8

src/interfacing/sensor_interfacing/launch/include/cameras.launch.py#L18-L29 

     serial = LaunchConfiguration('serial', default="'18542606'")
     serial_arg = DeclareLaunchArgument('serial', default_value=serial,
                                        description='FLIR serial number of camera (in quotes!!)')
-    
+
     # extra_params = { 'debug': True,
-                    #  'device_link_throughput_limit': 125000000,
-                    #  'gev_scps_packet_size': 1440,
-                    #  }
+    #  'device_link_throughput_limit': 125000000,
+    #  'gev_scps_packet_size': 1440,
+    #  }
 
     camera_node = Node(
         package='spinnaker_camera_driver',

Check failure on line 43 in src/interfacing/sensor_interfacing/launch/include/cameras.launch.py

See this annotation in the file changed.

@github-actions github-actions / Autopep8

src/interfacing/sensor_interfacing/launch/include/cameras.launch.py#L33-L43 

         parameters=[
             # extra_params,
             {
-                    'parameter_file': parameter_file,
-                    'serial_number': [serial],
-                    }]
-                    ,
+                'parameter_file': parameter_file,
+                'serial_number': [serial],
+            }],
         remappings=[
             ('~/control', '/exposure_control/control'),
         ])

Check failure on line 57 in src/interfacing/sensor_interfacing/launch/include/cameras.launch.py

See this annotation in the file changed.

@github-actions github-actions / Autopep8

src/interfacing/sensor_interfacing/launch/include/cameras.launch.py#L48-L57 

         name='debayer_node',
         remappings=[
             ('/image_raw', '/flir_camera/image_raw'),
-    ]
+        ]
     )
-
 
     return LaunchDescription([
         parameter_file_arg,

Check failure on line 44 in src/interfacing/sensor_interfacing/launch/include/lidars.launch.py

See this annotation in the file changed.

@github-actions github-actions / Autopep8

src/interfacing/sensor_interfacing/launch/include/lidars.launch.py#L21-L44 

                                 output='both',
                                 parameters=[params])
 
-
     convert_share_dir = get_package_share_directory('velodyne_pointcloud')
-    convert_params_file = os.path.join(convert_share_dir, 'config', 'VLP32C-velodyne_transform_node-params.yaml')
+    convert_params_file = os.path.join(
+        convert_share_dir, 'config', 'VLP32C-velodyne_transform_node-params.yaml')
     with open(convert_params_file, 'r') as f:
         convert_params = yaml.safe_load(f)['velodyne_transform_node']['ros__parameters']
-    convert_params['calibration'] = os.path.join(convert_share_dir, 'params', 'VeloView-VLP-32C.yaml')
+    convert_params['calibration'] = os.path.join(
+        convert_share_dir, 'params', 'VeloView-VLP-32C.yaml')
     velodyne_transform_node = Node(package='velodyne_pointcloud',
-                                                      executable='velodyne_transform_node',
-                                                      output='both',
-                                                      parameters=[convert_params])
+                                   executable='velodyne_transform_node',
+                                   output='both',
+                                   parameters=[convert_params])
 
     laserscan_share_dir = get_package_share_directory('velodyne_laserscan')
-    laserscan_params_file = os.path.join(laserscan_share_dir, 'config', 'default-velodyne_laserscan_node-params.yaml')
+    laserscan_params_file = os.path.join(
+        laserscan_share_dir, 'config', 'default-velodyne_laserscan_node-params.yaml')
     velodyne_laserscan_node = Node(package='velodyne_laserscan',
-                                                      executable='velodyne_laserscan_node',
-                                                      output='both',
-                                                      parameters=[laserscan_params_file])
+                                   executable='velodyne_laserscan_node',
+                                   output='both',
+                                   parameters=[laserscan_params_file])
 
     return LaunchDescription([
         velodyne_driver_node,
View more details on GitHub Actions