Skip to content

adding a linter workflow #197

adding a linter workflow

adding a linter workflow #197

Triggered via pull request February 5, 2024 17:03
Status Cancelled
Total duration 2m 35s
Artifacts

build_and_unitest.yml

on: pull_request
Setup environment
7s
Setup environment
Matrix: Build Image and Run Unit Testing Suite
Fit to window
Zoom out
Zoom in

Annotations

66 errors and 2 notices
src/samples/python/producer/setup.py#L10
packages=[package_name], data_files=[ # Install marker file in the package index - ('share/ament_index/resource_index/packages', ['resource/' + package_name]), + ('share/ament_index/resource_index/packages', + ['resource/' + package_name]), # Include our package.xml file (os.path.join('share', package_name), ['package.xml']), # Include all launch files (os.path.join('share', package_name, 'launch'), glob(os.path.join('launch', '*.launch.py'))), # Include config files for parameters - (os.path.join('share', package_name, 'config'), glob(os.path.join('config', '*.yaml'))), + (os.path.join('share', package_name, 'config'), + glob(os.path.join('config', '*.yaml'))), ], install_requires=['setuptools'], zip_safe=True,
src/samples/python/producer/producer/producer_node.py#L36
pos_x = self.get_parameter('pos_x').get_parameter_value().double_value pos_y = self.get_parameter('pos_y').get_parameter_value().double_value pos_z = self.get_parameter('pos_z').get_parameter_value().double_value - velocity = self.get_parameter('velocity').get_parameter_value().double_value + velocity = self.get_parameter( + 'velocity').get_parameter_value().double_value # Initialize producer core logic for serialization self.__producer = ProducerCore(pos_x, pos_y, pos_z, velocity) # Initialize ROS2 constructs queue_size = 10 - self.publisher_ = self.create_publisher(Unfiltered, '/unfiltered_topic', queue_size) + self.publisher_ = self.create_publisher( + Unfiltered, '/unfiltered_topic', queue_size) timer_period = 0.5 self.timer = self.create_timer(timer_period, self.__publish_position)
src/samples/python/aggregator/setup.py#L10
packages=[package_name], data_files=[ # Install marker file in the package index - ('share/ament_index/resource_index/packages', ['resource/' + package_name]), + ('share/ament_index/resource_index/packages', + ['resource/' + package_name]), # Include our package.xml file (os.path.join('share', package_name), ['package.xml']), # Include all launch files.
src/samples/python/aggregator/aggregator/aggregator_node.py#L54
str(self.__aggregator.num_filtered_msgs)) self.get_logger().info('Producer Frequency:' + str(self.__aggregator.raw_freq)) - self.get_logger().info('Transformer Frequency:' + str(self.__aggregator.filtered_freq)) + self.get_logger().info('Transformer Frequency:' + + str(self.__aggregator.filtered_freq)) def main(args=None):
src/samples/python/transformer/setup.py#L10
packages=[package_name], data_files=[ # Install marker file in the package index - ('share/ament_index/resource_index/packages', ['resource/' + package_name]), + ('share/ament_index/resource_index/packages', + ['resource/' + package_name]), # Include our package.xml file (os.path.join('share', package_name), ['package.xml']), # Include all launch files. (os.path.join('share', package_name, 'launch'), glob(os.path.join('launch', '*.launch.py'))), # Include config files for parameters - (os.path.join('share', package_name, 'config'), glob(os.path.join('config', '*.yaml'))), + (os.path.join('share', package_name, 'config'), + glob(os.path.join('config', '*.yaml'))), ], install_requires=['setuptools'], zip_safe=True,
src/samples/python/transformer/transformer/transformer_node.py#L35
self.__transformer = TransformerCore() # Initialize ROS2 Constructs - self.publisher_ = self.create_publisher(FilteredArray, '/filtered_topic', 10) + self.publisher_ = self.create_publisher( + FilteredArray, '/filtered_topic', 10) self.subscription = self.create_subscription(Unfiltered, '/unfiltered_topic', self.unfiltered_callback, 10)
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L17
import time import torch + class CameraDetectionNode(Node):
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L32
self.declare_parameter('model_path', '/perception_models/yolov8s.pt') self.declare_parameter('image_size', 480) self.declare_parameter('compressed', False) - + self.camera_topic = self.get_parameter('camera_topic').value self.publish_vis_topic = self.get_parameter('publish_vis_topic').value - self.publish_detection_topic = self.get_parameter('publish_detection_topic').value + self.publish_detection_topic = self.get_parameter( + 'publish_detection_topic').value self.model_path = self.get_parameter('model_path').value self.image_size = self.get_parameter('image_size').value self.compressed = self.get_parameter('compressed').value
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L80
self.stride = int(self.model.stride) # setup vis publishers - self.vis_publisher = self.create_publisher(Image, self.publish_vis_topic, 10) - self.detection_publisher = self.create_publisher(Detection2DArray, self.publish_detection_topic, 10) - - self.get_logger().info(f"Successfully created node listening on camera topic: {self.camera_topic}...") + self.vis_publisher = self.create_publisher( + Image, self.publish_vis_topic, 10) + self.detection_publisher = self.create_publisher( + Detection2DArray, self.publish_detection_topic, 10) + + self.get_logger().info( + f"Successfully created node listening on camera topic: {self.camera_topic}...") def preprocess_image(self, cv_image): """
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L190
# preprocess image and run through prediction img = self.preprocess_image(cv_image) - processed_cv_image = LetterBox(self.image_size, stride=self.stride)(image=cv_image) + processed_cv_image = LetterBox( + self.image_size, stride=self.stride)(image=cv_image) pred = self.model(img) # nms function used same as yolov8 detect.py
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L227
self.publish_vis(annotated_img, feed) self.publish_detections(detections, msg, feed) - self.get_logger().info(f"Finished in: {time.time() - startTime}, {1/(time.time() - startTime)} Hz") - + self.get_logger().info( + f"Finished in: {time.time() - startTime}, {1/(time.time() - startTime)} Hz") def main(args=None):
src/perception/camera_object_detection/camera_object_detection/yolov8_detection.py#L239
camera_object_detection_node.destroy_node() rclpy.shutdown() + if __name__ == '__main__': main()
src/perception/camera_object_detection/launch/sim_launch.py#L5
from ament_index_python.packages import get_package_share_directory import os import yaml + def generate_launch_description(): ld = LaunchDescription()
src/perception/camera_object_detection/launch/nuscenes_launch.py#L5
from ament_index_python.packages import get_package_share_directory import os import yaml + def generate_launch_description(): ld = LaunchDescription()
src/perception/camera_object_detection/launch/deepracer_launch.py#L5
from ament_index_python.packages import get_package_share_directory import os import yaml + def generate_launch_description(): ld = LaunchDescription()
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L4
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L13
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L14
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L14
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L16
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L17
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L21
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L22
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L22
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L23
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L23
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L24
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L24
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L25
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L26
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L28
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L29
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L35
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis_node.hpp#L38
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis.hpp#L4
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis.hpp#L12
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis.hpp#L15
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis.hpp#L16
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/include/radar_vis.hpp#L20
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L1
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L6
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L7
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L9
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L10
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L11
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L11
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L12
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L13
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L14
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L17
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L18
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L21
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L25
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis_node.cpp#L25
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L1
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L8
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L11
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L14
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L15
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/src/radar_vis.cpp#L53
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/test/radar_vis_test.cpp#L1
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/test/radar_vis_test.cpp#L11
code should be clang-formatted [-Wclang-format-violations]
src/perception/radar_object_detection/radar_vis/test/radar_vis_test.cpp#L49
code should be clang-formatted [-Wclang-format-violations]
src/samples/cpp/aggregator/include/aggregator_core.hpp#L4
code should be clang-formatted [-Wclang-format-violations]
src/samples/cpp/aggregator/include/aggregator_core.hpp#L9
code should be clang-formatted [-Wclang-format-violations]
Setup environment
Using eddy-add-linting-workflow as the source branch
Setup environment
Using main as the target branch