redirect to ticket url path after login (#140) #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansonjwhe
approved these changes
Dec 21, 2023
frontend/src/components/Navbar.js
Outdated
| @@ -14,7 +14,7 @@ const Navbar = () => { | |||
| setLoading(true) | |||
| try { | |||
| await login() | |||
| navigate('/') | |||
| //navigate("/") //LoggedInRedirect already does this | |||
There was a problem hiding this comment.
can remove this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used location states to save url in private route when user not logged in, then after login, redirects to the url.
I had an infinite loop at some point, but for some reason it's working. So please test this on your local machine first before merging. I tested every possibility and it works for me.
I also have no actual links to test this with, but in theory this works