Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Additions, DTMF + NCCO #527

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Voice Additions, DTMF + NCCO #527

merged 2 commits into from
Nov 27, 2024

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Nov 27, 2024

This PR adds the synchronous and asynchronous modes to the Input NCCO, and the DTMF realtime event endpoints to the Voice Client.

Description

When using an Input DTMF, you can now set the mode. You cannot add DTMF settings to an Input NCCO if you have set it to async.

There are also two new endpoints, called with the following methods:
subscribeToDtmfEventsById() where you can add eventUrls to post DTMF events to
unsubscribeToDtmfEventsById() where you can stop the listener.

This gives overall control of whether you want individual events per DTMF keypress or whether to get the input keystrokes back batched.

Motivation and Context

Parity with voice API features.

How Has This Been Tested?

Tests added for this functionality.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK merged commit 945eec9 into main Nov 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant