Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed captions on whatsapp audio #522

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Nov 8, 2024

This PR removes the ability to add a caption to a WhatsAppAudio Object.

Description

Captions are not supported on the API, so this shouldn't have been an available feature. Nothing will get rendered if you pass a caption in, though it will now throw a warning.

How Has This Been Tested?

Tests have been adjusted accordingly.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK merged commit fac2469 into main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant