Update tests to use VbcConfig

Vonage · May 3, 2019 · 68a1d51 · 68a1d51
1 parent 2fe13b8
commit 68a1d51
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/src/Application/Application.php b/src/Application/Application.php
@@ -230,16 +230,22 @@ public function jsonSerialize()
         }
 
         // Handle VBC specifically
-        if ($this->vbcConfig->isEnabled()) {
+        if ($this->getVbcConfig()->isEnabled()) {
             $capabilities['vbc'] = new \StdClass;
         }
 
+        // Workaround API bug. It expects an object and throws 500
+        // if it gets an array
+        if (!count($capabilities)) {
+            $capabilities = (object) $capabilities;
+        }
+
         return [
             'name' => $this->getName(),
             'keys' => [
                 'public_key' => $this->getPublicKey()
             ],
-            'capabilities' => (object) $capabilities
+            'capabilities' => $capabilities
         ];
     }
 

diff --git a/src/Application/Client.php b/src/Application/Client.php
@@ -236,7 +236,7 @@ protected function createFromArrayV1($array) {
 
         // VBC
         if (isset($array['vbc']) && $array['vbc']) {
-            $application->enableVbc();
+            $application->getVbcConfig()->enable();
         }
 
         return $application;
@@ -303,7 +303,7 @@ protected function createFromArrayV2($array) {
 
         // Handle VBC
         if (isset($capabilities['vbc'])) {
-            $application->enableVbc();
+            $application->getVbcConfig()->enable();
         }
 
         return $application;

diff --git a/test/Application/ApplicationTest.php b/test/Application/ApplicationTest.php
@@ -105,7 +105,7 @@ public function testResponseSetsRtcConfigs()
     public function testResponseSetsVbcConfigs()
     {
         $this->app->setResponse($this->getResponse());
-        $this->assertEquals(true, $this->app->isVbcEnabled());
+        $this->assertEquals(true, $this->app->getVbcConfig()->isEnabled());
     }
 
     public function testCanGetDirtyValues()

diff --git a/test/Application/ClientTest.php b/test/Application/ClientTest.php
@@ -463,7 +463,7 @@ public function createApplication()
         $application->getMessagesConfig()->setWebhook(MessagesConfig::INBOUND, 'https://example.com/inbound', 'POST');
         $application->getRtcConfig()->setWebhook(RtcConfig::EVENT, 'https://example.com/event', 'POST');
         $application->setPublicKey('-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCA\nKOxjsU4pf/sMFi9N0jqcSLcjxu33G\nd/vynKnlw9SENi+UZR44GdjGdmfm1\ntL1eA7IBh2HNnkYXnAwYzKJoa4eO3\n0kYWekeIZawIwe/g9faFgkev+1xsO\nOUNhPx2LhuLmgwWSRS4L5W851Xe3f\nUQIDAQAB\n-----END PUBLIC KEY-----\n');
-        $application->enableVbc();
+        $application->getVbcConfig()->enable();
 
         $rawV1 = [
             'name' => 'test application',