feat: Add support for proxies in HttpConfig #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
============================================
+ Coverage 95.60% 96.00% +0.39%
- Complexity 3427 3754 +327
============================================
Files 513 564 +51
Lines 8141 8704 +563
Branches 451 497 +46
============================================
+ Hits 7783 8356 +573
+ Misses 198 175 -23
- Partials 160 173 +13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set a proxy URL without needing to use the deprecated
VonageClient.Builder#httpClientmethod. This can instead be configured directly inHttpConfigwithout exposing details of the underlying HTTP client implementation.