Skip to content

Commit

Permalink
Merge pull request #281 from TimotheeL/AppEndpoint
Browse files Browse the repository at this point in the history
App endpoint
  • Loading branch information
yallen011 authored Aug 13, 2020
2 parents 559deac + 3495f08 commit ed26b8d
Show file tree
Hide file tree
Showing 4 changed files with 105 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [5.3.1]
### Added
- Added AppEndpoint for ConnectAction

## [5.3.0]
### Added
- Added support for new voice names added to the Voice API for [Text to Speech](https://developer.nexmo.com/voice/voice-api/guides/text-to-speech)
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ documentation, or tests are eligible to be added to this list.
- John Schultz ([@jwschultz](https://github.com/jwschultz))
- Steve Lorello ([@sloello89])(https://github.com/slorello89)
- Yvonne Allen ([@yallen011](https://github.com/yallen011))
- Timothee Laurent ([@TimotheeL])(https://github.com/TimotheeL)
62 changes: 62 additions & 0 deletions src/main/java/com/nexmo/client/voice/ncco/AppEndpoint.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
* Copyright (c) 2011-2020 Nexmo Inc
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package com.nexmo.client.voice.ncco;

import com.fasterxml.jackson.annotation.JsonInclude;

/**
* Represents an app endpoint used in a {@link ConnectAction}
*/
@JsonInclude(value = JsonInclude.Include.NON_NULL)
public class AppEndpoint implements Endpoint {

private static final String TYPE = "app";
private String user;

private AppEndpoint(Builder builder) {
this.user = builder.user;
}

public String getType() {
return TYPE;
}

public String getUser() {
return user;
}

public static Builder builder(String user) {
return new Builder(user);
}

public static class Builder {
private String user;

public Builder(String user) {
this.user = user;
}

public AppEndpoint build() {
return new AppEndpoint(this);
}
}
}
38 changes: 38 additions & 0 deletions src/test/java/com/nexmo/client/voice/ncco/AppEndpointTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Copyright (c) 2011-2020 Nexmo Inc
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package com.nexmo.client.voice.ncco;

import org.junit.Test;

import static org.junit.Assert.assertEquals;

public class AppEndpointTest {
@Test
public void testAppEndpoint() {
AppEndpoint endpoint = AppEndpoint.builder("testUser")
.build();
ConnectAction connect = ConnectAction.builder(endpoint).build();

String expectedJson = "[{\"endpoint\":[{\"user\":\"testUser\",\"type\":\"app\"}],\"action\":\"connect\"}]";
assertEquals(expectedJson, new Ncco(connect).toJson());
}
}

0 comments on commit ed26b8d

Please sign in to comment.