Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appearance): changes in listitem appearance colors (VIV-1648) #1637

Merged
merged 6 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion libs/components/src/lib/data-grid/data-grid-cell.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@use '../../../../../dist/libs/tokens/scss/size.variables' as size;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent cta,
$shades: primary primary-text primary-increment faint pale dim,
$shades: primary primary-text primary-increment firm soft faint pale dim,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
2 changes: 1 addition & 1 deletion libs/components/src/lib/data-grid/data-grid-row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@use 'partials/variables' as variables;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent cta,
$shades: primary primary-text primary-increment faint pale dim,
$shades: primary primary-text primary-increment firm faint soft pale dim,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion libs/components/src/lib/menu-item/menu-item.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use '../../../../../dist/libs/tokens/scss/tokens.constants' as constants;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent,
$shades: primary primary-text primary-increment faint soft pale dim,
$shades: primary primary-text primary-increment firm faint soft pale dim,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion libs/components/src/lib/option/option.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@use '../../../../../dist/libs/tokens/scss/tokens.constants' as constants;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent,
$shades: primary primary-text primary-increment faint soft pale dim,
$shades: primary primary-text primary-increment firm faint soft pale dim,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
2 changes: 1 addition & 1 deletion libs/components/src/lib/time-picker/time-picker.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use '../../../../../dist/libs/tokens/scss/tokens.constants' as constants;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent,
$shades: primary faint soft dim pale,
$shades: primary firm faint soft dim pale,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use '../../../../../dist/libs/tokens/scss/tokens.constants' as constants;
@use '../../../../shared/src/lib/sass/mixins/connotation/config' with (
$connotations: accent,
$shades: primary faint soft dim pale,
$shades: primary firm faint soft dim pale,
$default: accent
);
@use '../../../../shared/src/lib/sass/mixins/connotation' as connotation;
Expand Down
22 changes: 11 additions & 11 deletions libs/shared/src/lib/sass/mixins/appearance/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: transparent,
outline: transparent,
),
Expand Down Expand Up @@ -77,7 +77,7 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(faint)}),
outline: transparent,
),
Expand Down Expand Up @@ -114,7 +114,7 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(soft)}),
outline: transparent,
),
Expand Down Expand Up @@ -225,8 +225,8 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
fill: var(#{connotation.get-connotation-token(dim)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(soft)}),
outline: transparent,
),
),
Expand Down Expand Up @@ -262,8 +262,8 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
fill: var(#{connotation.get-connotation-token(pale)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(dim)}),
outline: transparent,
),
),
Expand Down Expand Up @@ -336,8 +336,8 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
fill: var(#{connotation.get-connotation-token(dim)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(soft)}),
outline: transparent,
),
),
Expand Down Expand Up @@ -373,8 +373,8 @@ $states-mapping: (
outline: transparent,
),
listitem: (
text: var(#{connotation.get-connotation-token(primary)}),
fill: var(#{connotation.get-connotation-token(pale)}),
text: var(#{connotation.get-connotation-token(firm)}),
fill: var(#{connotation.get-connotation-token(dim)}),
outline: transparent,
),
),
Expand Down
Loading