Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): policy docs (VIV-1558) #1635

Merged
merged 12 commits into from
Mar 14, 2024
Merged

chore(docs): policy docs (VIV-1558) #1635

merged 12 commits into from
Mar 14, 2024

Conversation

TaylorJ76
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (dc161f3).
Report is 862 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1635     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       312    +189     
  Lines         1562      5032   +3470     
  Branches       108       563    +455     
===========================================
+ Hits          1562      5032   +3470     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RichardHelm RichardHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a lot of the accessibility guidelines seems to be coming from https://www.pie.design/accessibility/overview/

I don't think we can or should just copy their content directly, so we should rephrase / rework it at least a bit more

apps/docs/_includes/navigation.njk Outdated Show resolved Hide resolved
@@ -0,0 +1,40 @@
# Accessibility overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headings should be in title case

Suggested change
# Accessibility overview
# Accessibility Overview


We use automated testing tools to audit our components for WCAG compliance, ensuring we follow best practices seamlessly.

We estimate that **automated testing can detect a large number of common WCAG issues**. Automated testing also gives your team more time to focus on the more complex accessibility tests that need to be completed manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, in the previous Accessibility guidelines we stated that only ~30% of issues are found

docs/accessibility/resources.md Outdated Show resolved Hide resolved
James Taylor and others added 2 commits March 14, 2024 11:09
@TaylorJ76 TaylorJ76 merged commit 661b83c into main Mar 14, 2024
16 checks passed
@TaylorJ76 TaylorJ76 deleted the VIV-1558-policy-docs branch March 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants