-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): policy docs (VIV-1558) #1635
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 312 +189
Lines 1562 5032 +3470
Branches 108 563 +455
===========================================
+ Hits 1562 5032 +3470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but a lot of the accessibility guidelines seems to be coming from https://www.pie.design/accessibility/overview/
I don't think we can or should just copy their content directly, so we should rephrase / rework it at least a bit more
docs/accessibility/overview.md
Outdated
@@ -0,0 +1,40 @@ | |||
# Accessibility overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headings should be in title case
# Accessibility overview | |
# Accessibility Overview |
docs/accessibility/testing.md
Outdated
|
||
We use automated testing tools to audit our components for WCAG compliance, ensuring we follow best practices seamlessly. | ||
|
||
We estimate that **automated testing can detect a large number of common WCAG issues**. Automated testing also gives your team more time to focus on the more complex accessibility tests that need to be completed manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right, in the previous Accessibility guidelines we stated that only ~30% of issues are found
Co-authored-by: Richard Helm <[email protected]>
Co-authored-by: Richard Helm <[email protected]>
No description provided.