Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-area): style resize knob (VIV-1620) #1626

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

rachelbt
Copy link
Contributor

@rachelbt rachelbt commented Mar 6, 2024

  • Firefox is not supported, but it also has a different style where the knob is bigger and not hidden under the box-shadow (the outline).
  • The ui tests are not presenting the resize knob in FF & safari at all- @YonatanKra maybe you know why?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (7b7ef52).
Report is 855 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1626     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       312    +189     
  Lines         1562      5026   +3464     
  Branches       108       563    +455     
===========================================
+ Hits          1562      5026   +3464     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rachelbt rachelbt merged commit 9c9a9fc into main Mar 7, 2024
16 checks passed
@rachelbt rachelbt deleted the VIV-1620-resizer branch March 7, 2024 12:19
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants