Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): format json, yml and html (VIV-1605) #1619

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

RichardHelm
Copy link
Contributor

As a first step, code formatting for just these file types

@RichardHelm RichardHelm force-pushed the VIV-1605-format-json-yml-html branch 2 times, most recently from c544d1a to 366b494 Compare March 1, 2024 16:23
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (ec69071).
Report is 850 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1619     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       316    +193     
  Lines         1562      5057   +3495     
  Branches       108       563    +455     
===========================================
+ Hits          1562      5057   +3495     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the indentation are so "big"?
image

How will we keep the indentation aligned - we (vivid devs) are using both vs code and WebStorm

@RichardHelm
Copy link
Contributor Author

@rachelbt Files are formatted with tabs (as it's set in our .editorconfig). You can configure how wide a tab appears in GitHub: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-user-account-settings/managing-your-tab-size-rendering-preference

The CI pipeline enforces the formatting and will fail if new code is not properly formatted.

Dev's should setup their IDE to auto-format code as they write it, see: https://prettier.io/docs/en/editors

@rachelbt
Copy link
Contributor

rachelbt commented Mar 5, 2024

Dev's should setup their IDE to auto-format code as they write it, see: https://prettier.io/docs/en/editors

think we need to add this somewhere in the docs (internal, not site)

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichardHelm RichardHelm merged commit 7351841 into main Mar 5, 2024
16 checks passed
@RichardHelm RichardHelm deleted the VIV-1605-format-json-yml-html branch March 5, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants