-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): format json, yml and html (VIV-1605) #1619
Conversation
c544d1a
to
366b494
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 316 +193
Lines 1562 5057 +3495
Branches 108 563 +455
===========================================
+ Hits 1562 5057 +3495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachelbt Files are formatted with tabs (as it's set in our The CI pipeline enforces the formatting and will fail if new code is not properly formatted. Dev's should setup their IDE to auto-format code as they write it, see: https://prettier.io/docs/en/editors |
think we need to add this somewhere in the docs (internal, not site) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a first step, code formatting for just these file types