Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): link doesn't work when it's inside the data-grid (VIV-1587) #1612

Closed
wants to merge 5 commits into from

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Feb 28, 2024

No description provided.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (d57563f).
Report is 839 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1612     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       316    +193     
  Lines         1562      5056   +3494     
  Branches       108       562    +454     
===========================================
+ Hits          1562      5056   +3494     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue with the button link not opening is not related to the link button but to the data-grid.
Look at this cpode pen - the button-link is OK outside the data grid but inside the data-grid both the plain link and button link are not opening:
https://codepen.io/Rachel-Tannenbaum/pen/ZEZEOeB

@rinaok
Copy link
Contributor Author

rinaok commented Feb 29, 2024

the issue with the button link not opening is not related to the link button but to the data-grid. Look at this cpode pen - the button-link is OK outside the data grid but inside the data-grid both the plain link and button link are not opening: https://codepen.io/Rachel-Tannenbaum/pen/ZEZEOeB

@rachelbt I know that but it was the only way I found to fix the button link inside the data-grid.

@rinaok rinaok requested a review from rachelbt February 29, 2024 09:55
@rinaok rinaok closed this Feb 29, 2024
@rinaok rinaok deleted the VIV-1587-button-link branch February 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants