Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(range-slider): add component (VIV-1488) #1584

Merged
merged 17 commits into from
Feb 28, 2024

Conversation

RichardHelm
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (a11ca3c).
Report is 837 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1584     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       316    +193     
  Lines         1562      5055   +3493     
  Branches       108       562    +454     
===========================================
+ Hits          1562      5055   +3493     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rinaok
rinaok previously requested changes Feb 20, 2024
Copy link
Contributor

@rinaok rinaok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navigation does not contain the component.

@rachelbt
Copy link
Contributor

The navigation does not contain the component.

this is because we decided to have one or 2 teams checking the component before we add it to the "public" :)

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
left 2 comments

libs/components/src/lib/range-slider/range-slider.scss Outdated Show resolved Hide resolved
@rachelbt
Copy link
Contributor

The navigation does not contain the component.

this is because we decided to have one or 2 teams checking the component before we add it to the "public" :)

but you can see it with adding the component name:
https://vivid-fd8y50sq3b1b.deno.dev/components/range-slider

Copy link
Contributor

@TaylorJ76 TaylorJ76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Only thing I noticed was that the screen reader (voiceover on mac) was not reading out the minus values correctly.
Eg: "-4" is being read as "4". I can see that the code is correct, but I wonder if we need to investigate why.

@RichardHelm
Copy link
Contributor Author

@TaylorJ76 Well spotted, this seems to be an issue with VoiceOver: https://discussions.apple.com/thread/254773710?sortBy=best

It also affects other components like slider, number-field etc. so I think a possible fix / workaround is out of scope for this PR

@RichardHelm RichardHelm dismissed stale reviews from rachelbt and rinaok February 28, 2024 12:00

Stale

@RichardHelm RichardHelm merged commit 0074811 into main Feb 28, 2024
16 checks passed
@RichardHelm RichardHelm deleted the VIV-1488-add-range-slider branch February 28, 2024 15:26
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
RichardHelm added a commit that referenced this pull request Feb 29, 2024
* feat(range-slider): add component (VIV-1488)

* Add range-slider to vivid-vue

* Add component override

* Update snapshot

* Update snapshot

* Update snapshots

* Refactor track-start position

* Fix keyboard navigation in vertical orientation

* Use logical properties

---------

Co-authored-by: James Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants