-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(range-slider): add component (VIV-1488) #1584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 316 +193
Lines 1562 5055 +3493
Branches 108 562 +454
===========================================
+ Hits 1562 5055 +3493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6aef70c
to
774be81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navigation does not contain the component.
this is because we decided to have one or 2 teams checking the component before we add it to the "public" :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
left 2 comments
but you can see it with adding the component name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Only thing I noticed was that the screen reader (voiceover on mac) was not reading out the minus values correctly.
Eg: "-4" is being read as "4". I can see that the code is correct, but I wonder if we need to investigate why.
@TaylorJ76 Well spotted, this seems to be an issue with VoiceOver: https://discussions.apple.com/thread/254773710?sortBy=best It also affects other components like slider, number-field etc. so I think a possible fix / workaround is out of scope for this PR |
* feat(range-slider): add component (VIV-1488) * Add range-slider to vivid-vue * Add component override * Update snapshot * Update snapshot * Update snapshots * Refactor track-start position * Fix keyboard navigation in vertical orientation * Use logical properties --------- Co-authored-by: James Taylor <[email protected]>
No description provided.