Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new comment on models #260

Conversation

RignonNoel
Copy link
Contributor

@RignonNoel RignonNoel commented Oct 1, 2020

Q R
Type of contribution ? Features
Tickets (issues) concerned #248

QUESTIONS

I have some questions opn how you want me to integrate this.

....dwqdwq

What have you changed ?

Added a new stripe integration to manage donation
Change some Models to keep donation in database
...

How did you change it ?
  1. Created some ENV variable to keep Stripe key
  2. Created some migrations for database to keep schema up to date
Is there a special consideration?
  • You need to have a Stripe key and to put it into your .env file (lien stripe pour key)
  • You will need to run the migrate command of Django to update your DB before running this version

Verification :

  • My branch name respect the standard defined in CONTRIBUTING.md
  • All my commits respect the standard defined in CONTRIBUTING.md
  • This Pull-Request fully meets the requirements defined in the issue
  • I added or modified the attached tests
  • I added or modified the documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 67a57c1 on RignonNoel:feature-add_stripe_integration_for_donation into f5ccbe5 on Volontaria:develop.

@RignonNoel RignonNoel closed this Oct 3, 2020
@imanethepe
Copy link

First request: Not complying with all requirements in the template.
-succeeded to fix my installation by installing requirements and finding the way to hide my secrets keys.
-guessing that I need to re-install the directory projectdonation in api_volontaria because it is actually at the same level as API-Volontaria.
-About the code proojectdonation.py, stripe.js is requested. My guess is to make 1 payment with the public key of the user and generating 1 token per payment.

@imanethepe imanethepe mentioned this pull request Oct 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants