Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests #538

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Update e2e tests #538

merged 13 commits into from
Nov 12, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #513

@vitPinchuk vitPinchuk self-assigned this Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (c4ca454) to head (276e10d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files         115      115           
  Lines        1981     1986    +5     
  Branches      519      519           
=======================================
+ Hits         1965     1970    +5     
  Misses         14       14           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Oct 31, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.9.0 milestone Oct 31, 2024
@mikhail-vl
Copy link
Member

mikhail-vl commented Oct 31, 2024 •
edited
Loading

@vitPinchuk If some tests are failing on 10.0.0, we can increase to 10.3.0 used in several panels already.

asimonok
asimonok requested changes Nov 8, 2024
View reviewed changes
test/utils/form.ts Outdated Show resolved Hide resolved
test/panel.spec.ts Outdated Show resolved Hide resolved
test/panel.spec.ts Outdated Show resolved Hide resolved
test/panel.spec.ts Outdated Show resolved Hide resolved
test/utils/form.ts Outdated Show resolved Hide resolved
test/utils/form.ts Outdated Show resolved Hide resolved
@vitPinchuk
Copy link
Contributor Author

Left issue issues:1316 about import and modules issue

asimonok
asimonok approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 7b9df92 into main Nov 12, 2024
8 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-e2e-test branch November 12, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.9.0
Development

Successfully merging this pull request may close these issues.

Add E2E tests
3 participants
@vitPinchuk @mikhail-vl @asimonok