[TRAC-6] Implement Message Service and basic Command Handling #7
Conversation
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Component; | ||
| import org.telegram.telegrambots.meta.generics.TelegramClient; | ||
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| @Getter |
There was a problem hiding this comment.
Why do you need this getter?
| private final String command; | ||
| private final String description; | ||
|
|
||
| Command(String command, String description) { |
There was a problem hiding this comment.
You can use @requiredargsconstructor instead of creating manually constructor
| @Getter | ||
| public enum Command { | ||
|
|
||
| START("/start", "Welcome to TrackMyCoin 📈💰!\nThis bot helps you track cryptocurrency prices\nand will send you notifications when your target price \nis reached.\n\nFor more information about the bot, type /info."), |
There was a problem hiding this comment.
Please move all static values (text) to application.yml
There was a problem hiding this comment.
Also, please create task in Jira to move this values from application.yml to database. It will increase flexibility in changes for us
| @Autowired | ||
| private TelegramBotClient telegramBotClient; | ||
|
|
||
| private final List<Command> commands = List.of(Command.START , Command.INFO , Command.HELP); |
There was a problem hiding this comment.
Please use strategy pattern
There was a problem hiding this comment.
should be like this
commandProcessorsRegistry.getProcessor(Command).process(chatId)
| try { | ||
| telegramBotClient.getTelegramClient().execute(message); | ||
| } catch (TelegramApiException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
never just print stack trace, you should use log
| } | ||
| } | ||
|
|
||
| private void sendWelcomeMessage(Long chatId , String messageText) { |
There was a problem hiding this comment.
This is separate responsibility (SRP), not for MessageHandler
Move this method to telegramBotClient
| @@ -0,0 +1,14 @@ | |||
| FROM maven:3.9.4-eclipse-temurin-21-alpine as build | |||
No description provided.