Merge pull request #274 from Vizzuality/fix-conservation-builder-page…

…-type Fix incorrect type prop in the ConservationBuilderPage + typing
Vizzuality · Jun 21, 2024 · 61908d5 · 61908d5
2 parents c8c741f + 08b78ac
commit 61908d5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/frontend/src/containers/map/sidebar/index.tsx b/frontend/src/containers/map/sidebar/index.tsx
@@ -16,7 +16,7 @@ import LayersPanel from './layers-panel';
 import MainPanel, { PANEL_TYPES } from './main-panel/panels';
 
 type MapSidebarProps = {
-  type: keyof typeof PANEL_TYPES;
+  type: (typeof PANEL_TYPES)[keyof typeof PANEL_TYPES];
 };
 
 const MapSidebar: FCWithMessages<MapSidebarProps> = ({ type }) => {

diff --git a/frontend/src/containers/map/sidebar/main-panel/panels/index.tsx b/frontend/src/containers/map/sidebar/main-panel/panels/index.tsx
@@ -14,7 +14,7 @@ const SIDEBAR_COMPONENTS = {
 };
 
 type PanelsProps = {
-  type: keyof typeof PANEL_TYPES;
+  type: (typeof PANEL_TYPES)[keyof typeof PANEL_TYPES];
 };
 
 const MainPanel: FCWithMessages<PanelsProps> = ({ type }) => {

diff --git a/frontend/src/layouts/map.tsx b/frontend/src/layouts/map.tsx
@@ -18,7 +18,7 @@ const LAYOUT_TYPES = {
 export interface MapLayoutProps {
   title?: string;
   description?: string;
-  type: keyof typeof LAYOUT_TYPES;
+  type: (typeof LAYOUT_TYPES)[keyof typeof LAYOUT_TYPES];
 }
 
 const MapLayout: FCWithMessages<PropsWithChildren<MapLayoutProps>> = ({
@@ -41,7 +41,11 @@ const MapLayout: FCWithMessages<PropsWithChildren<MapLayoutProps>> = ({
   return (
     <>
       <Head
-        title={!title.length && type === 'conservation_builder' ? t('conservation-builder') : title}
+        title={
+          !title.length && type === LAYOUT_TYPES.conservation_builder
+            ? t('conservation-builder')
+            : title
+        }
         description={description}
       />
       <div className="flex h-screen w-screen flex-col">

diff --git a/frontend/src/pages/conservation-builder/[locationCode].tsx b/frontend/src/pages/conservation-builder/[locationCode].tsx
@@ -26,7 +26,7 @@ ConservationBuilderPage.layout = {
   Component: MapLayout,
   props: {
     title: '',
-    type: 'conservation_builder',
+    type: 'conservation-builder',
   },
 };