Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export and import lockStatusSetByUser flag [MRXN23-599] #1660

Conversation

hotzevzl
Copy link
Member

@hotzevzl hotzevzl commented Mar 10, 2024

The lockStatusSetByUser scenario PU flag had not been added to piece exporters and importers, leading to loss of this data when cloning scenarios. This change fixes this.

Testing instructions

Set some PUs to excluded, some to available and some to included for a scenario.

Clone the scenario (or its whole parent project). The new copy of the scenario must preserve the statuses set manually in the source scenario.

Feature relevant tickets

https://vizzuality.atlassian.net/browse/MRXN23-600


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 11:17am

@hotzevzl
Copy link
Member Author

yolo'ing and fast-tracking this to production, with promise to get back to the failing tests

@hotzevzl hotzevzl merged commit 255c7f6 into develop Mar 11, 2024
60 of 61 checks passed
@hotzevzl hotzevzl deleted the fix/api/MRXN23-599_export-and-import-lock-status-set-by-user-flag branch March 11, 2024 13:05
@hotzevzl
Copy link
Member Author

yolo'ing and fast-tracking this to production, with promise to get back to the failing tests

promise fulfilled by Kevin here: #1664 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants