[FE](fix): remove automatic back action when saved PAs and show save btn only when necessary [MRXN23-547] #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anamontiaga
changed the title
anamontiaga
requested review from
mbarrenechea
and removed request for
agnlez and
mbarrenechea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove automatic back action when saved PAs and show save button only when necessary
Overview
After clicking save in some cases you go back to the previous tab (Protected areas) or you stay in the same (features).
We should make this consistent.
This PR is a solution, removing the goBack action when saving threshold and disable mutation when threshold has been not changed, as protected areas are already saved in previous step.
Also, selected features mutation is disable when there is no changes.
In both cases an info toast has been added:
Here is some extra info about why we are not disabling button and we are just disabling mutations:
https://axesslab.com/disabled-buttons-suck
Feature relevant tickets
MRXN23-547