Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts for scenario report generation [MRXN23-503] #1608

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

yulia-bel
Copy link
Contributor

@yulia-bel yulia-bel commented Dec 14, 2023

Increase timeouts for scenario report generation

Overview

In some cases when generating pdf report for scenario some solutions maps are left empty.

This PR increases webshot timeout from 30 to 60 seconds and in FE increases timeout for setting MARXAN.webshot_ready to true to 10 seconds

Designs

Testing instructions

Manual testing done with Okavango project - before timeouts increase 3 out of 5 maps were empty, after the increase all 5 maps are printed correctly.
project_okavango-scenario_new_scenario-run_after.pdf
project_okavango-scenario_new_scenario-run_before.pdf

Feature relevant tickets

MRXN23-530


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:25pm

@yulia-bel yulia-bel merged commit e155a77 into develop Dec 14, 2023
14 checks passed
@yulia-bel yulia-bel deleted the fix/api/MRXN23-503-map-print-in-scenario-report branch December 14, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants