Fixes missing min/max update for default CostSurface metadata for non shapefile based Projects [MRXN23-522] #1599
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KevSanchez
force-pushed
the
fix/api/MRXN23-522-min-max-values-on-default-cost-surfaces-for-non-shapefile-based-projects
branch
from
8fbafdf to
c9f1433
Compare
There was a problem hiding this comment.
@KevSanchez thank you, and great job on the cleanup of the test fixtures 🚀
It's ready to go - just have a look at the two notes about added exports that don't seem to be needed, probably some leftovers of IDE trying to be useful.
|
|
||
| type CustomPlanningAreaJob = Required< | ||
| export type CustomPlanningAreaJob = Required< |
There was a problem hiding this comment.
tiny: why the added export? I don't see this type used anywhere else (maybe an IDE overzealousness added this?)
| @@ -2,10 +2,13 @@ import * as faker from 'faker'; | |||
| import { PlanningUnitsJob } from '@marxan-jobs/planning-unit-geometry'; | |||
| import { PlanningUnitGridShape } from '@marxan/scenarios-planning-unit'; | |||
|
|
|||
| interface OptionsWithCountryCode { | |||
| export interface OptionsWithCountryCode { | |||
There was a problem hiding this comment.
same as for the other export above - not really an issue, but this interface isn't used elsewhere other than in this file
There was a problem hiding this comment.
True, it's not really needed. I think at some point while I was developing I needed both in an earlier iteration, but forgot about it. Good catch!
…e metadata for non shapefile based Projects
KevSanchez
force-pushed
the
fix/api/MRXN23-522-min-max-values-on-default-cost-surfaces-for-non-shapefile-based-projects
branch
from
c9f1433 to
6e55523
Compare
KevSanchez
deleted the
fix/api/MRXN23-522-min-max-values-on-default-cost-surfaces-for-non-shapefile-based-projects
branch
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)