Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRXN23-498]: fixes many crashes due to disabling pagination #1573

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

andresgnlez
Copy link
Member

Substitute this line for a meaningful title for your changes

Overview

This PR aims to fix the crashes produced by disabling pagination in several endpoints.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

https://vizzuality.atlassian.net/browse/MRXN23-498


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@andresgnlez andresgnlez added the Frontend Everything related frontend label Nov 8, 2023
@andresgnlez andresgnlez self-assigned this Nov 8, 2023
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 5:42pm

@hotzevzl hotzevzl merged commit 26ef6a2 into develop Nov 10, 2023
12 checks passed
@hotzevzl hotzevzl deleted the MRXN23-499-fe-app-may-crash-in-some branch November 10, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Everything related frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants