Copy amount per PU for shapefiles and legacy [MRXN23-466] [MRXN23-467] #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KevSanchez
changed the title
hotzevzl
approved these changes
Oct 26, 2023
Comment on lines
386
to
419
| private async updateAmountMinMaxForAPIFeatures( | ||
| apiEntityManager: EntityManager, | ||
| featureIds: string[], | ||
| ): Promise<void> { | ||
| this.logger.log(`Saving min and max amounts for new features...`); | ||
|
|
||
| const minAndMaxAmountsForFeatures = await this.geoprocessingEntityManager | ||
| .createQueryBuilder() | ||
| .select('feature_id', 'id') | ||
| .addSelect('MIN(amount)', 'amountMin') | ||
| .addSelect('MAX(amount)', 'amountMax') | ||
| .from('feature_amounts_per_planning_unit', 'fappu') | ||
| .where('fappu.feature_id IN (:...featureIds)', { featureIds }) | ||
| .groupBy('fappu.feature_id') | ||
| .getRawMany(); | ||
|
|
||
| const minMaxSqlValueStringForFeatures = minAndMaxAmountsForFeatures | ||
| .map( | ||
| (feature) => | ||
| `(uuid('${feature.id}'), ${feature.amountMin}, ${feature.amountMax})`, | ||
| ) | ||
| .join(', '); | ||
|
|
||
| const query = ` | ||
| update features set | ||
| amount_min = minmax.min, | ||
| amount_max = minmax.max | ||
| from ( | ||
| values | ||
| ${minMaxSqlValueStringForFeatures} | ||
| ) as minmax(feature_id, min, max) | ||
| where features.id = minmax.feature_id;`; | ||
| await apiEntityManager.query(query); | ||
| } |
There was a problem hiding this comment.
ok to keep this in this PR - in a later one, I suggest to use a single instance of this code, after adding a parameter to allow to pass in an apiEntityManager and removing the reliance on any entity managers injected in the parent class, so that we can remove duplicated code... though if moving this to an existing lib (for example libs/geofeature-calculations) turns out to be even just slightly more than banal, duplication be it and let's move on with life.
hotzevzl
force-pushed
the
feature/api/MRXN23-466-467-copy-amount-per-pu-for-shapefiles-and-legacy
branch
from
0f206c6 to
2ac1fc3
Compare
hotzevzl
deleted the
feature/api/MRXN23-466-467-copy-amount-per-pu-for-shapefiles-and-legacy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)