[api] Add range of amounts (min, max) for feature per PU [MRXN23-444] #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yulia-bel
force-pushed
the
feature/api/MRXN23-444-range-of-amount-for-feature-per-pu
branch
from
b5ca654 to
9f2dcc1
Compare
hotzevzl
reviewed
Oct 18, 2023
There was a problem hiding this comment.
thanks @yulia-bel! just some performance notes to make sure things work smoothly irrespective(ish) of how many puvspr_records are in a given instance, for how many distinct feature_ids, and of how many features we want to set min/max for at once (through the new GeoFeaturesService.saveAmountRangeForFeatures() method)
api/apps/api/src/modules/geo-features/import/features-amounts-upload.service.ts
Show resolved
Hide resolved
yulia-bel
force-pushed
the
feature/api/MRXN23-444-range-of-amount-for-feature-per-pu
branch
from
0f1db02 to
7172b6a
Compare
hotzevzl
reviewed
Oct 19, 2023
api/apps/api/src/modules/geo-features/import/features-amounts-upload.service.ts
Outdated
Show resolved
Hide resolved
hotzevzl
approved these changes
Oct 20, 2023
hotzevzl
deleted the
feature/api/MRXN23-444-range-of-amount-for-feature-per-pu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add range of amounts (min, max) for feature
Overview
This PR adds 2 new columns to (apiDB).features table to store min and and amount values.
As agreed before, service (in GeoFeaturesServices) will retrieve values from (geoDB)puvspr_calculations table by featureId and save them to (apiDB).features table. the serviced will be reused for all feature types..
Tests updated accordingly and to be reviewed when implementing https://vizzuality.atlassian.net/browse/MRXN23-460 (currently null values are being saved)
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)