(chore) cost surface data migration script #1501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
alexeh
commented
Sep 18, 2023
| min_val, max_val = min_max if min_max else (None, None) | ||
|
|
||
| # If min and max are null, remove scenario and cost_surface from api_db | ||
| if min_val is None or max_val is None: |
There was a problem hiding this comment.
Please give extra love to this part
alexeh
commented
Sep 18, 2023
| INNER JOIN planning_units_geom pug ON pug.id = ppu.geom_id | ||
| WHERE ppu.project_id = '{project_id}'; | ||
| """) | ||
|
|
There was a problem hiding this comment.
TODO: insert for each scenario in apiDB
alexeh
commented
Sep 18, 2023
| print(len(all_projects), "projects") | ||
| except Exception as e: | ||
| print(e) | ||
| cur_api_db.execute("ROLLBACK;") |
There was a problem hiding this comment.
TODO: All ops in one single transaction: one commit, one rollback
|
closing as we included this, with some tweaks, in #1494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script for handling the data migration for existing projects and scenarios.
NOTE: Since this will be run most likely from NOT the host, I haven't add any requirements.txt.
Overview
API:
For each scenario, create a cost surface within the project, and set it as the scenarios cost surface. We use the scenario name as cost surface name
For each project, create a new cost surface using 'Default' as name, and set it as default cost surface for the project.
GEO & API
for each scenario in api, get its cost surface and compute min and max from scenario_pu_cost_data.
update api.cost_surface with said min,max
for each project, get its default cost surface and insert it's default cost in cost_surface_pu_data
update the the api.cost_surface computing the min and max from the new cost
Error handling
There might be scenarios in API that has no cost in GEO. I have assumed this should not happen, so I am deleting the scenario and its cost_surface in API
I don't know if the same could happen for projects
Testing instructions
Basically the above should happen
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)