FE: tailwind config updates [MRXN23-450] #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anamontiaga
added
Frontend
|
@anamontiaga things I've found so far:
|
andresgnlez
reviewed
Sep 15, 2023
app/tailwind.config.js
Outdated
| }, | ||
| fontFamily: { | ||
| heading: 'Poppins', | ||
| sans: [ |
There was a problem hiding this comment.
I don't think we need to set the whole list of fonts available, just add ours and let the rest of them be the default ones: https://tailwindcss.com/docs/font-family#customizing-the-default-font
There was a problem hiding this comment.
Same for serif and mono families.
|
Good job overall, I was expecting this to be way worse 👏🏻 👏🏻 |
andresgnlez
force-pushed
the
MRXN23-450-tailwind-updates
branch
from
48aa85d to
c5d5a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailwind config updates
Overview
This PR change tailwind config styles to disable old custom styles and override tailwind styles extending ones.
Also updates main colors in config and trough the app.
NOTE: Old tailwind configs are still in the project with
_oldprefixDesigns
Figma Design System
Feature relevant tickets
MRXN23-450