Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] (feat): Inventory panel: Protected Areas [MRXN23-239] #1456

Merged
merged 28 commits into from
Sep 11, 2023

Conversation

andresgnlez
Copy link
Member

@andresgnlez andresgnlez commented Aug 28, 2023

Protected Areas by project

NOTE: on hold until API is ready.

Overview

This PR includes the inventory panel protected areas section with MOCKED DATA

Actions included:

  • List Protected Areas by project
  • Edit Protected Area: rename
  • Delete Protected Area
  • Bulk Delete Protected Areas
  • Sort Protected Area by name
  • Search Protected Area by name
  • Upload Protected Areas at project level via shapefile
  • Display Protected Area on map

Designs

https://www.figma.com/file/0xD4gR9pCqU7NROnlSW6ck/Marxan-Layout---Redesign?node-id=605%3A28284&mode=dev

Testing

Screenshot 2023-08-29 at 12 48 36

Feature relevant tickets

MRXN23-239

@andresgnlez andresgnlez added the Frontend Everything related frontend label Aug 28, 2023
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 0:27am

@anamontiaga anamontiaga changed the title [MRXN23-290]: list Protected Areas by project [MRXN23-290][MRXN23-298][MRXN23-299][MRXN23-300]: Protected Areas by project Aug 28, 2023
@anamontiaga anamontiaga added the WIP Work in progress label Aug 28, 2023
@anamontiaga anamontiaga changed the title [MRXN23-290][MRXN23-298][MRXN23-299][MRXN23-300]: Protected Areas by project [FE] (feat): Inventory panel: Protected Areas [MRXN23-290][MRXN23-298][MRXN23-299][MRXN23-300][MRXN23-301][MRXN23-302][MRXN23-309] Aug 29, 2023
@anamontiaga anamontiaga added Ready to review PR ready to review and removed WIP Work in progress labels Aug 29, 2023
@andresgnlez andresgnlez marked this pull request as ready for review August 30, 2023 07:36
onClick={onSortChange}
/>
</th>
{columns['name'] && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach will not scale. Can we pass an array of headers to the table an just render them? Like:

const headers = [
{
text: 'Name',
name: 'name',
columns,
sorting, 
onSortChange,
...,
{
...
}
]

@andresgnlez
Copy link
Member Author

@anamontiaga
image

Correct me if I am wrong, but when I add several PAs to the map, we should probably iterate over different colours so we can differentiate them. Also, the name of the PA should be listed in the legend below Protected areas preview along with its colour.

@anamontiaga
Copy link
Collaborator

@anamontiaga image

Correct me if I am wrong, but when I add several PAs to the map, we should probably iterate over different colours so we can differentiate them. Also, the name of the PA should be listed in the legend below Protected areas preview along with its colour.

@andresgnlez As mentioned, the same color is maintained for the protected preview areas (blue) but the legend should show the list of WDPAs on the map

@anamontiaga anamontiaga added WIP Work in progress and removed Ready to review PR ready to review labels Aug 30, 2023
@anamontiaga anamontiaga force-pushed the MRXN23-290-list-protected-areas-by branch from 36d7fda to d0919e5 Compare September 11, 2023 12:23
@andresgnlez andresgnlez merged commit 829e1ea into develop Sep 11, 2023
12 checks passed
@andresgnlez andresgnlez deleted the MRXN23-290-list-protected-areas-by branch September 11, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Everything related frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants