filter out feature amounts per PU rows where amount is not a positive…

… number [MRXNM-43] Reason: the Marxan solver will show unexpected behaviour when it sees `puvspr.dat` rows with amount = 0.
Vizzuality · Apr 23, 2024 · e7ced45 · e7ced45
1 parent eaf7a07
commit e7ced45
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...s-per-planning-unit/src/repository/memory-feature-amounts-per-planning-unit.repository.ts b/...s-per-planning-unit/src/repository/memory-feature-amounts-per-planning-unit.repository.ts
@@ -26,8 +26,12 @@ export class MemoryFeatureAmountsPerPlanningUnitRepository
 
     if (!featureAmountsPerPlanningUnit) return [];
 
-    return featureAmountsPerPlanningUnit.filter(({ featureId }) =>
-      featureIds.includes(featureId),
+    return (
+      featureAmountsPerPlanningUnit
+        .filter(({ featureId }) => featureIds.includes(featureId))
+        /** The Marxan solver will show unexpected behaviour when seeing
+         * puvspr.dat rows with amount = 0 */
+        .filter(({ amount }) => amount > 0)
     );
   }
   async saveAmountPerPlanningUnitAndFeature(

diff --git a/...-per-planning-unit/src/repository/typeorm-feature-amounts-per-planning-unit.repository.ts b/...-per-planning-unit/src/repository/typeorm-feature-amounts-per-planning-unit.repository.ts
@@ -40,6 +40,9 @@ export class TypeormFeatureAmountsPerPlanningUnitRepository
       .from(FeatureAmountsPerPlanningUnitEntity, 'fappu')
       .where('project_id = :projectId', { projectId })
       .andWhere('feature_id IN (:...featureIds)', { featureIds })
+      /** The Marxan solver will show unexpected behaviour when seeing
+       * puvspr.dat rows with amount = 0 */
+      .andWhere('amount > 0')
       .execute();
   }