feat(CostSurface): Update Cost Surface PR tweaks and Develop Rebase

Vizzuality · Sep 8, 2023 · a9a6005 · a9a6005
1 parent 808a425
commit a9a6005
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/api/apps/api/src/modules/cost-surface/cost-surface.service.ts b/api/apps/api/src/modules/cost-surface/cost-surface.service.ts
@@ -87,10 +87,10 @@ export class CostSurfaceService {
       return left(projectNotEditable);
     }
 
-    const nameCount = await this.costSurfaceRepository.count({
-      where: { name: dto.name },
+    const sameNameCostSurface = await this.costSurfaceRepository.count({
+      where: { projectId, name: dto.name },
     });
-    if (nameCount > 0) {
+    if (sameNameCostSurface) {
       return left(costSurfaceNameAlreadyExistsForProject);
     }
 

diff --git a/api/apps/api/src/modules/cost-surface/dto/update-cost-surface.dto.ts b/api/apps/api/src/modules/cost-surface/dto/update-cost-surface.dto.ts
@@ -1,4 +1,3 @@
-import { PartialType } from '@nestjs/swagger';
 import { CreateCostSurfaceDto } from '@marxan-api/modules/cost-surface/dto/create-cost-surface.dto';
 
-export class UpdateCostSurfaceDto extends PartialType(CreateCostSurfaceDto) {}
+export class UpdateCostSurfaceDto extends CreateCostSurfaceDto {}
diff --git a/api/apps/api/src/modules/cost-surface/dto/upload-cost-surface-shapefile.dto.ts b/api/apps/api/src/modules/cost-surface/dto/upload-cost-surface-shapefile.dto.ts
@@ -1,3 +1,3 @@
-import { UpdateCostSurfaceDto } from '@marxan-api/modules/cost-surface/dto/update-cost-surface.dto';
+import { CreateCostSurfaceDto } from '@marxan-api/modules/cost-surface/dto/create-cost-surface.dto';
 
-export class UploadCostSurfaceShapefileDto extends UpdateCostSurfaceDto {}
+export class UploadCostSurfaceShapefileDto extends CreateCostSurfaceDto {}
diff --git a/api/apps/api/src/modules/projects/project-cost-surface.controller.ts b/api/apps/api/src/modules/projects/project-cost-surface.controller.ts
@@ -43,6 +43,9 @@ import {
   JsonApiAsyncJobMeta,
 } from '@marxan-api/dto/async-job.dto';
 import { ensureShapefileHasRequiredFiles } from '@marxan-api/utils/file-uploads.utils';
+import { UpdateCostSurfaceDto } from '@marxan-api/modules/cost-surface/dto/update-cost-surface.dto';
+import { CostSurfaceSerializer } from '@marxan-api/modules/cost-surface/dto/cost-surface.serializer';
+import { JSONAPICostSurface } from '@marxan-api/modules/cost-surface/cost-surface.api.entity';
 
 @ApiTags(projectResource.className)
 @Controller(`${apiGlobalPrefixes.v1}/projects`)
@@ -51,6 +54,7 @@ export class ProjectCostSurfaceController {
     @Inject(forwardRef(() => ScenariosService))
     public readonly scenarioService: ScenariosService,
     public readonly costSurfaceService: CostSurfaceService,
+    public readonly costSurfaceSeralizer: CostSurfaceSerializer,
   ) {}
 
   @ImplementsAcl()
@@ -105,8 +109,8 @@ export class ProjectCostSurfaceController {
     @Param('projectId') projectId: string,
     @Param('costSurfaceId') costSurfaceId: string,
     @Req() req: RequestWithAuthenticatedUser,
-    @Body() dto: UploadCostSurfaceShapefileDto,
-  ): Promise<NotImplementedException> {
+    @Body() dto: UpdateCostSurfaceDto,
+  ): Promise<JSONAPICostSurface> {
     const result = await this.costSurfaceService.updateCostSurfaceShapefile(
       req.user.id,
       projectId,

diff --git a/api/apps/api/test/project/project-cost-surface.controller.e2e-spec.ts b/api/apps/api/test/project/project-cost-surface.controller.e2e-spec.ts
@@ -43,7 +43,7 @@ describe('Upload Cost Surface Shapefile', () => {
   });
 });
 
-describe('Upload Cost Surface Shapefile', () => {
+describe('Update Cost Surface', () => {
   beforeEach(async () => {
     fixtures = await getProjectCostSurfaceControllerFixtures();
   });
@@ -58,17 +58,14 @@ describe('Upload Cost Surface Shapefile', () => {
     const costSurfaceName = 'someNewName';
 
     // ACT
-    const response = await fixtures.WhenUpdatingCostSurfaceForProject(
+    await fixtures.WhenUpdatingCostSurfaceForProject(
       projectId,
       costSurface.id,
       costSurfaceName,
     );
 
     // ASSERT
-    await fixtures.ThenCostSurfaceAPIEntityWasProperlySaved(
-      response,
-      costSurfaceName,
-    );
+    await fixtures.ThenCostSurfaceAPIEntityWasProperlySaved(costSurfaceName);
   });
 
   it(`should return error when the cost surface could not be found`, async () => {