Add mobile version of the countries emissions bubble chart #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintomas
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
I have tested this and looks good to me ;). Just two minor comments:
- maybe it would be nice if you could click on country name and it would redirect you to country detail (same way that allows you to click on bubble at bubble chart)
- It feels to me that orientation of dropdown arrows is reversed
You are right! I made the changes you suggested. Thanks |
martintomas
deleted the
client/feature/LSE-126-mobile-version-of-bubble-chart-all-countries-ascor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the mobile (devices smaller than 992px) version of the ascor countries bubble chart