Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address an issue with the scroll behaviour and close button of the detailed view #859

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

clementprdhomme
Copy link
Member

@clementprdhomme clementprdhomme commented Mar 27, 2024

This PR fixes an issue where the detailed view of a project would scroll to the top when clicking in the background. It also make the close button always reachable.

Testing instructions

  • Go to search/catalogue page
  • Click on any of the projects in the list
  • Scroll down
  • Click anywhere in the preview card

Expected results

  • The closing functionality remains visible (fixed)
  • The page remains where I scrolled

Tracking

LET-1439

@clementprdhomme clementprdhomme self-assigned this Mar 27, 2024
@clementprdhomme clementprdhomme merged commit bec547c into develop Apr 3, 2024
1 check passed
@clementprdhomme clementprdhomme deleted the LET-1439-project-preview-card-issues branch April 3, 2024 07:33
SARodrigues pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant