fix: admin mailer view format + update tests #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulia-bel
force-pushed
the
fix/backend-admin-mailer-new-accounts
branch
from
e9b5fee to
903efe0
Compare
martintomas
approved these changes
Nov 30, 2023
|
|
||
| it "renders the body" do | ||
| expect(mail.body.encoded).to match(I18n.t("admin_mailer.greetings", full_name: admin.full_name)) | ||
| expect(mail.body.encoded).to match(I18n.t("admin_mailer.project_developer_created.content_html", new_pd_url: "")) |
There was a problem hiding this comment.
I would recommend to test also whole url inside mailer and not just new_pd_url: "". You should be able to use here link_to('New Investor', backoffice_investor_url(investor)) -- only part which is missing to make this work is I think url helper (backoffice_investor_url) which is added automatically to request tests here: https://github.com/Vizzuality/heco-invest/blob/develop/backend/spec/rails_helper.rb#L41. You can modify this line and add these helpers also to mailer tests which should give you all methods you need.
There was a problem hiding this comment.
thanks! seems like adding helpers directly to tests have worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for previous admin notifications for new accounts creation:
Testing instructions
admin_mailer_spec.rb extended to cover project_developer_created and investor_created mailer views
Tracking
Link to the task(s), if any