Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LET-1383 [BE] Change tourism-and-recreation for sustainable-tourism #785

Merged
merged 8 commits into from
Nov 24, 2023

Conversation

yulia-bel
Copy link
Contributor

This PR is BE part for replacing Tourism and recreation for Sustainable tourism (LET-1376) and includes following updates:

  • Update category model and replace tourism-and-recreation with sustainable-tourism
  • Migration file that will replace in existing data all the category values of tourism-and-recreation for sustainable-tourism (in tables projects, investors and project_developers)
  • Update of the tests and snapshots accordingly
  • Update of the swagger documentation

Testing instructions

Actual tests are updated and cover the implemented changes (since no new functionality has been introduced).
The results of running new Migration in local database:

before migration

Screenshot from 2023-11-23 11-12-47
Screenshot from 2023-11-23 11-12-12
Screenshot from 2023-11-23 11-11-30

after migration

Screenshot from 2023-11-23 11-46-41
Screenshot from 2023-11-23 11-46-17
Screenshot from 2023-11-23 11-45-52

Tracking

1383

Copy link
Collaborator

@martintomas martintomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)

Copy link
Contributor

@agnessa agnessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just take into account that there are references to the old slug in the FE code. unless agreed otherwise, perhaps we could update the FE code as well not to break this?

@martintomas
Copy link
Collaborator

looks good, just take into account that there are references to the old slug in the FE code. unless agreed otherwise, perhaps we could update the FE code as well not to break this?

Good point, I hoped that they don't use it hardcoded anywhere 🤔 . From my point of view, it should be enough to just replace it everywhere on FE

@yulia-bel yulia-bel merged commit 946b310 into develop Nov 24, 2023
4 checks passed
@yulia-bel yulia-bel deleted the backend/LET-1383-change-for-sustainable-tourism branch November 24, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants