Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LET-1379 [BE] Add new attributes and form fields for projects #783

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

yulia-bel
Copy link
Contributor

@yulia-bel yulia-bel commented Nov 21, 2023

This PR is BE part for adding new form fields when creating and editing projects (LET-1375) and includes following updates:

  • Migration file to add 8 new attributes (2 text fields in 3 different languages, 1 decimal for revenue and 1 boolean that specifies if details for one of the 2 text field - related to climate change risks - is provided or not)
  • Adding new attributes to serializer and permitted params where needed
  • Update of the view for the form in Backoffice to include new fields for the attributes, adding new attributes to permitted params in Backoffice
  • Updating factories, snapshots and tests where needed

Testing instructions

Existing automated tests and factories are updated and adjusted to include testing new attributes

Tracking

Link to the task(s), if any
LET-1379

positive_financial_returns: If your current business model generates positive financial returns, please explain what they consist of
last_year_sales_revenue: What was the sales revenue in the last fiscal year-end?
climate_change_risks_identified: Has the project identified the risks of climate change to which the business is exposed and potential mitigation strategies?
climate_change_risks_details: If yes, please, discribe these risks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo at discribe

Copy link
Contributor

@agnessa agnessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 great work!

@yulia-bel yulia-bel merged commit c7d6d66 into develop Nov 23, 2023
3 checks passed
@yulia-bel yulia-bel deleted the backend/LET-1379-add-fields-to-project branch November 23, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants