Assignment 1,2 added #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishalYadav405
commented
Aug 5, 2023
VishalYadav405
commented
Aug 5, 2023
VishalYadav405
commented
Aug 5, 2023
AdarshR217
reviewed
Aug 5, 2023
|
|
||
|
|
||
|
|
||
| func clearFirestoreData() { |
There was a problem hiding this comment.
move this function outside didFinishLaunching
AdarshR217
reviewed
Aug 5, 2023
AdarshR217
reviewed
Aug 5, 2023
Assignment1/Assignment1/Controller/SuggestionViewController.swift
Outdated
Show resolved
Hide resolved
AdarshR217
reviewed
Aug 5, 2023
Assignment1/Assignment1/Controller/SuggestionViewController.swift
Outdated
Show resolved
Hide resolved
AdarshR217
reviewed
Aug 12, 2023
| let dbComponents = DataBaseComponents.singletonDataBaseComponents | ||
| dbComponents.clearFirestoreData() | ||
|
|
||
| do{ |
AdarshR217
reviewed
Aug 12, 2023
| lazy var persistentContainer: NSPersistentContainer = { | ||
| let container = NSPersistentContainer(name: "Model") | ||
| container.loadPersistentStores(completionHandler: { (storeDescription, error) in | ||
| if let error = error as NSError? { |
AdarshR217
reviewed
Aug 12, 2023
| for doc in snapShotDoc { | ||
| self.items.append(doc.data()) | ||
| DispatchQueue.main.async { | ||
| self.tableView.reloadData() |
There was a problem hiding this comment.
why is table reloading for every item ?
AdarshR217
reviewed
Aug 12, 2023
| if let image = loadImage(productArrayCoreData[indexPath.row].image_url){ | ||
| cell.itemImage.image = image | ||
| } | ||
| cell.itemPrice.text = productArrayCoreData[indexPath.row].price |
There was a problem hiding this comment.
Merge the data from both productArrayCoreData and productArray
AdarshR217
reviewed
Aug 12, 2023
| cell.itemImage.image = image | ||
| } | ||
|
|
||
| cell.itemPrice.text = "Rs. \(notNilInfoItem["discounted_price"]!)" |
AdarshR217
reviewed
Aug 12, 2023
|
|
||
|
|
||
|
|
||
| // |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.