Resolve bugs #100
Merged
Resolve bugs #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o getDisplayListSegment
This was referenced Nov 21, 2018
asadeg02
force-pushed
the
resolve-bugs
branch
from
83d996e to
73b830d
Compare
|
Going ahead and merging this one into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96 #97 #98 #89 #88. Aslo the Error in browser for #97 is fixed but the rendering is empty and messy since this sbol file involves a production having 4 participants (which are Rna regions) and there's an assumption in the code for production to only render those production interaction having 3 participants, There are also SBOs for which there aren't any roles in SBOToRole file.
below are the renderings after fixing the bugs: