Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bop corrections #43

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Bop corrections #43

wants to merge 22 commits into from

Conversation

rakayash
Copy link
Contributor

Check for BoP power consumption and BoP control

kvid and others added 14 commits January 19, 2023 17:49
-Change units for library from unspecified type to Modelica SI/NonSI units
-Fixed issue for example models where some defined parameters was not translated to correct levels
-Added parameter propagation for number of cells in stack to subsystem control
-Added lower and upper limits to parameter list for EMS block
-Added parameter grouping for rangeExtenderPowertrain
pump, blower and compressor have individual drive records
@rakayash rakayash requested a review from benjamsy March 14, 2023 14:28
@kvid
Copy link
Contributor

kvid commented Mar 15, 2023

I suggest we make dev the base branch instead of main to enable merging several pull requests into dev and test them together before merging the combined changes into main as a new release. Do you want me to change that, or do you prefer to edit that yourself, @rakayash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants