Carl dymnatiks bug fix #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checker bug fixes - [x] Program array må gerne være af type string, argumenter skal altid være af type int - [x] array map skal initiliseres i array deklaration. som en stable ting - [x] Array Assignment gik tidligere ikke ingennem alle scopes for at prøve at finde variable. Fixet nu - [x] Vi håndtere ikke cassen med method call, hvilket smider fejl når den bruges, fordi den(Gettype) ikke kan resolve typen. var roomSize : int = room.size() - [x] Relational operations kunne ikke håndere sammenligning mellem 2 strings. kan nu
Har fundet kode som aldrig gør noget. har fjernet udkommenteret kode. Da det ikke var pænt
MShadiF
reviewed
May 16, 2024
| if (scopes.get(i).containsKey(node.getIdentifier())) { | ||
| return scopes.get(i).get(node.getIdentifier()); | ||
| } | ||
| } | ||
|
|
||
| // Det her kode gør ikke noget, bliver aldrig reached? |
There was a problem hiding this comment.
Tænker ikke jeg merger ind, hvis de her kode bider stadig er her. De skal nok fikses først før det bliver merget
MShadiF
reviewed
May 16, 2024
MShadiF
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeg har ændret hvordan vi kikker efter scope rundt omkring.
Og har udpeget steder hvor vi kan slette kode hvis Folk er med på den.
Jeg har kørt vores acceptence test og den virker ligesom test