Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #33

Merged
merged 1 commit into from
May 16, 2024
Merged

Bug fixes #33

merged 1 commit into from
May 16, 2024

Conversation

CarlHejlesen
Copy link
Collaborator

Type checker bug fixes

  • Program array må gerne være af type string, argumenter skal altid være af type int
  • Array Assignment gik tidligere ikke ingennem alle scopes for at prøve at finde variable. Fixet nu
  • Vi håndtere ikke cassen med method call, hvilket smider fejl når den bruges, fordi den(Gettype) ikke kan resolve typen. var roomSize : int = room.size()
  • Relational operations kunne ikke håndere sammenligning mellem 2 strings. kan nu

Type checker bug fixes
- [x] Program array må gerne være af type string, argumenter skal altid være af type int
- [x] array map skal initiliseres i array deklaration. som en stable ting
- [x] Array Assignment gik tidligere ikke ingennem alle scopes for at prøve at finde variable. Fixet nu
- [x] Vi håndtere ikke cassen med method call, hvilket smider fejl når den bruges, fordi den(Gettype) ikke kan resolve typen.  var roomSize : int = room.size()
- [x] Relational operations kunne ikke håndere sammenligning mellem 2 strings.  kan nu
Copy link
Collaborator

@MShadiF MShadiF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MShadiF MShadiF merged commit fea9ae0 into main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants