-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Refactor #72
CMake Refactor #72
Conversation
This reverts commit 45c5393.
Note to self: I still have to adjust the workflows and the app |
std::vector<cellType &> getNeighbors(const cellType &cell) { | ||
std::vector<cellType &> neighbors; | ||
auto cellSet = domain->getCellSet(); | ||
// What happened here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobre1 Was this some sort of merge conflict on your side?
I've evaluated some possible solutions but most are way too hacky to be deemed viable - I have thus raised an issue on VTKs side: https://gitlab.kitware.com/vtk/vtk/-/issues/19279. For now I'm going to add a |
The VTK libraries are now installed in the |
When building the examples, the binaries are now placed in |
When local ViennaLS/ViennaRay packages are used (specified in VIENNAPS_LOOKUP_DIRS), OpenMP is not added to the dependencies when building the examples. I get the following error:
|
Thanks for the thorough testing! I've updated the README and pushed a fix for ViennaRay (regarding OpenMP) here: ViennaTools/ViennaRay#48 Please try to install ViennaRay locally again with commit |
* This is useful when VTK is not installed through the package manager but by other means
VTK is working on a new way to make this possible, however it all seems to be highly work in progress right now |
This Pull Request modernizes CMake (resolves #56):
Use CPM / PackageProject
Update Include Structure
Copy required shared libraries when required / Setup proper path automatically when required
Modernize Python Bindings (integration with gdsfactory and other open source python based EDA tools #65)
os.add_dll_directory
) [⏳ Viaviennaps.libs
folder, awaiting upstream changes]Add library switch to ease location of installed dependencies (ViennaLS, ViennaRay, ...)